Return-Path: X-Original-To: apmail-hc-dev-archive@www.apache.org Delivered-To: apmail-hc-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 66316186F8 for ; Mon, 4 Jan 2016 20:24:40 +0000 (UTC) Received: (qmail 62608 invoked by uid 500); 4 Jan 2016 20:24:40 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 62462 invoked by uid 500); 4 Jan 2016 20:24:40 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 62305 invoked by uid 99); 4 Jan 2016 20:24:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Jan 2016 20:24:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id E7A072C1F69 for ; Mon, 4 Jan 2016 20:24:39 +0000 (UTC) Date: Mon, 4 Jan 2016 20:24:39 +0000 (UTC) From: "Oleg Kalnichevski (JIRA)" To: dev@hc.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (HTTPCLIENT-1700) CookieSpecBase & empty cookie names MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HTTPCLIENT-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCLIENT-1700. ------------------------------------------- Resolution: Fixed Fixed in SVN 4.5.x branch http://svn.apache.org/viewvc?rev=1722959&view=rev Please review / re-test. Oleg > CookieSpecBase & empty cookie names > ----------------------------------- > > Key: HTTPCLIENT-1700 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1700 > Project: HttpComponents HttpClient > Issue Type: Bug > Components: HttpCookie > Affects Versions: 4.5.1, 4.5.2 > Reporter: Michael Gardner > Priority: Minor > > As of HTTPCLIENT-1695, {{RFC6265CookieSpec}} accepts cookies with empty names. However, {{DefaultCookieSpec}} doesn't always choose this parser when it encounters such a cookie, and since {{CookieSpecBase}} rejects empty cookie names, we can end up with the same result unless we specify {{RFC6265CookieSpec}} explicitly (not ideal if we need to deal with a variety of sources). > In the interests of robustness, I would argue that {{CookieSpecBase}} should similarly ignore cookie with empty names rather than throw an exception ("be conservative in what you send, liberal in what you accept"). > Alternatively, {{DefaultCookieSpec}} could detect such cookies and parse them via {{RFC6265CookieSpec}}; but that would be more complex and might lead to other issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org