hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Gardner (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1700) CookieSpecBase & empty cookie names
Date Tue, 05 Jan 2016 19:13:39 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15083581#comment-15083581
] 

Michael Gardner commented on HTTPCLIENT-1700:
---------------------------------------------

Thanks!

The commit log says that the RFC 2965 cookie spec was included in the change, but the "empty
name" check still exists in RFC2965Spec.java. Oversight?

> CookieSpecBase & empty cookie names
> -----------------------------------
>
>                 Key: HTTPCLIENT-1700
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1700
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpCookie
>    Affects Versions: 4.5.1, 4.5.2
>            Reporter: Michael Gardner
>            Priority: Minor
>
> As of HTTPCLIENT-1695, {{RFC6265CookieSpec}} accepts cookies with empty names. However,
{{DefaultCookieSpec}} doesn't always choose this parser when it encounters such a cookie,
and since {{CookieSpecBase}} rejects empty cookie names, we can end up with the same result
unless we specify {{RFC6265CookieSpec}} explicitly (not ideal if we need to deal with a variety
of sources).
> In the interests of robustness, I would argue that {{CookieSpecBase}} should similarly
ignore cookie with empty names rather than throw an exception ("be conservative in what you
send, liberal in what you accept").
> Alternatively, {{DefaultCookieSpec}} could detect such cookies and parse them via {{RFC6265CookieSpec}};
but that would be more complex and might lead to other issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message