hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "munene kiruja (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HTTPCLIENT-1710) OSGiRoutePlanner examines only the first proxy exception and also crashes processing IP address exception
Date Wed, 30 Dec 2015 00:00:52 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

munene kiruja updated HTTPCLIENT-1710:
--------------------------------------
    Attachment: TestOSGiHttpRoutePlanner.java
                OSGiHttpRoutePlanner.java

A test class is also attached.

Also the deternineProxy loop checks exception lists for all ProxyConfiguration instances that
are registered in the system, but returns the proxy from the first encountered configuration
(there's no way to make a better decision at the moment)

> OSGiRoutePlanner examines only the first proxy exception and also crashes processing
IP address exception
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1710
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1710
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.4.1, 4.5, 5.0
>         Environment: OSGi
>            Reporter: munene kiruja
>             Fix For: 5.0
>
>         Attachments: OSGiHttpRoutePlanner.java, TestOSGiHttpRoutePlanner.java
>
>
> The HttpClientBuilderFactory and internal RoutePlanner objects are a fantastic addition
since 4.3.
> There are couple minor bugs rendering them unusable at the moment though.
> 1. The OSGiRoutePlanner.determinProxy() method only examines the first proxy exception.
> 2. When OSGiRoutePlanner.determinProxy() is creating a NetworkAddress from a String IP
address, it refers to the 6th capture group in a case where there are only four, leading to
an out of bounds exception.
> The class file is attached containing fixes for both issues at the 4.4.1 version. I checked
and found both issues existing in the trunk (5.0) at the time of this writing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message