hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1708) Issues With Extended ASCII ( Latin Chars ) Escaping with HttpClient 4.5.1
Date Mon, 28 Dec 2015 16:33:49 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15072888#comment-15072888
] 

Oleg Kalnichevski commented on HTTPCLIENT-1708:
-----------------------------------------------

I am not sure I understand. #toASCIIString is used precisely to ensure there are no non-ASCII
characters in the request line, given that URIs may contain ASCII characters only.

Could you please submit a test case reproducing the issue?

Oleg 

> Issues With Extended ASCII ( Latin Chars ) Escaping with HttpClient 4.5.1
> -------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1708
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1708
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.5.1
>         Environment: Ubuntu Variant 15.04
> Netbeans 8.1 IDE
> Java 8 ( Oracle JDK 1.8.6x)
>            Reporter: Idan Sheinberg
>
> Hey Guys
> Trying to send an httpclient HttpHead request for the following url  - 'http://some.domain.com/amnetcanadaplatform/HomeDépot_Électros_WEB22s_video.mp4'
> I Notice it gets escaped as 'http://some.domain.com/amnetcanadaplatform/HomeD%C3%A9pot_%C3%89lectros_WEB22s_video.mp4'
> While other programs/utilities/frameworks expect it to be 'http://some.domain.com/amnetcanadaplatform/HomeDe%CC%81pot_E%CC%81lectros_WEB22s_video.mp4'
> I've done some digging up the source code and tracked the issue down  to  "toASCIIString()"
of the Java URI ( WHICH OF COURSE IS NOT YOUR RESPONSIBILITY )object being called in order
to retrieve the request line
> Class : org.apache.http.client.methods.HttpRequestWrapper
> Method : getRequestLine() 
> Line : 113
> Internally the line 'String ns = Normalizer.normalize(s, Normalizer.Form.NFC);' manipulates
the chars so their unicode value changes , which causes the 'inappropriate' values to be displayed
for the escaped URI 
> Class : java.net.URI
> Method : encode(String s)
> Line : 2723
> Now I know this would extra hard to even get to a point where I find out if this is a
java language issue , but I don't believe unicode manipulation  of bytes is a desired behavior
 for url encoding. Is there any known specific why you used the "toASCIIString()" method instead
of the plain "toString()" method
> Do you think there's a chance this issue can be resolved on your end ?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message