hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1704) CookieSpecs.IGNORE_COOKIE policy CookieSpec#match returns true
Date Mon, 14 Dec 2015 16:40:46 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056246#comment-15056246
] 

Oleg Kalnichevski commented on HTTPCLIENT-1704:
-----------------------------------------------

It looked to me like an awfully awkward way of testing a method that always returned false.
Besides, it was misplaced to a completely unrelated test class to start with. If you are willing
provide test cases for IGNORE policy could you please make them more alike to what we already
have? Like TestDefaultCookieSpec or TestRFC6265CookieSpec?

Oleg  

> CookieSpecs.IGNORE_COOKIE policy CookieSpec#match returns true
> --------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1704
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1704
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.5.1, Snapshot
>            Reporter: Philippe Mouawad
>            Priority: Trivial
>             Fix For: 4.5.2, 5.0
>
>         Attachments: httpclient.patch
>
>
> Following:
> http://mail-archives.apache.org/mod_mbox/hc-httpclient-users/201512.mbox/%3CCAH9fUpYn6BDFUMA6qq-q4ioFsSQvd%2BFrLJCiSJXaAxnw1ZsBtg%40mail.gmail.com%3E
> When migrating from HTTPCLIENT3 to HC4.5 (issue is also in HC4.2.3), we have a change
in behaviour of org.apache.http.client.config.CookieSpec#match compared to org.apache.commons.httpclient.cookie.CookieSpec#match.
> In HC3, match returned false for IGNORE_POLICY while it now returns true.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message