Return-Path: X-Original-To: apmail-hc-dev-archive@www.apache.org Delivered-To: apmail-hc-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DE88717B93 for ; Sat, 3 Oct 2015 17:36:26 +0000 (UTC) Received: (qmail 39476 invoked by uid 500); 3 Oct 2015 17:36:26 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 39426 invoked by uid 500); 3 Oct 2015 17:36:26 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 39412 invoked by uid 99); 3 Oct 2015 17:36:26 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Oct 2015 17:36:26 +0000 Date: Sat, 3 Oct 2015 17:36:26 +0000 (UTC) From: "Michael Osipov (JIRA)" To: dev@hc.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HTTPCLIENT-1685) PublicSuffixDomainFilter.match() returns true for any simple host name. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HTTPCLIENT-1685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14942396#comment-14942396 ] Michael Osipov commented on HTTPCLIENT-1685: -------------------------------------------- I second that. > PublicSuffixDomainFilter.match() returns true for any simple host name. > ----------------------------------------------------------------------- > > Key: HTTPCLIENT-1685 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1685 > Project: HttpComponents HttpClient > Issue Type: Bug > Components: HttpClient > Affects Versions: 4.5 > Reporter: Alexander Bernstein > Priority: Minor > Labels: newbie > Fix For: 4.5.2 > > > HttpClient built by HttpClientBuilder ends up with publicSuffixMatcher created by PublicSuffixMatcherLoader.getDefault(). Later on, this object gets passed to CookieSpecRegistries.createDefault(publicSuffixMatcherCopy), if the cookieSpecRegistry is not set explicitly. > With this scenario, using simple host names (i.e. a name without a dot character, such as "server1" ) fails. > The reason seems to be the org.apache.http.impl.cookie.PublicSuffixDomainFilter.match(Cookie, CookieOrigin). This method returns a boolean indicating whether the domain is in the blacklist. > For any host name that is not a "localhost", the PublicSuffixMatcher.matches() is called, on line 76. This method returns true for any hostname that does not contain a dot charcter. Which causes the return false, on line 77. > Is this a correct behavior? If my server is called "server1", why should its name "match" a public suffix? And how do I make this code to recognize simple host names like this? If this is an expected behavior, is there a documented way to prevent it? -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org