hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCORE-412) Send HTTP trailers in request
Date Mon, 26 Oct 2015 10:27:27 GMT

    [ https://issues.apache.org/jira/browse/HTTPCORE-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14973991#comment-14973991

Oleg Kalnichevski commented on HTTPCORE-412:

You are welcome to disagree. 

This is however what the spec says on the matter
4.1.2.  Chunked Trailer Part

   A trailer allows the sender to include additional fields at the end
   of a chunked message in order to supply metadata that might be
   dynamically generated while the message body is sent, such as a
   message integrity check, digital signature, or post-processing
   status.  The trailer fields are identical to header fields, except
   they are sent in a chunked trailer instead of the message's header

Metadata that is available when the message head is generated might was well be sent in the
message head. There is no need to send it as trailers. 

Non-blocking code can be found here. It needs to be adjusted accordingly 

Catching all exceptions indiscriminately and re-throwing them all as IOException even though
those exceptions may have nothing to do with I/O is what looks ugly and wrong  

Why are using Callable in the first place?


> Send HTTP trailers in request
> -----------------------------
>                 Key: HTTPCORE-412
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-412
>             Project: HttpComponents HttpCore
>          Issue Type: New Feature
>          Components: HttpCore, HttpCore NIO
>            Reporter: Daneel Yaitskov
>             Fix For: 5.0
> Currently HTTP client doesn't support sending trailers to a web server.
> The section https://tools.ietf.org/html/rfc7230#section-4.4 is need to be implemented.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

View raw message