hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tobias Oberlies (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1688) ProxySelectorRoutePlanner doesn't handle IllegalStateException thrown by SchemeRegistry.getScheme
Date Mon, 12 Oct 2015 10:03:05 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952887#comment-14952887
] 

Tobias Oberlies commented on HTTPCLIENT-1688:
---------------------------------------------

I expected this answer, but I still wanted to make you aware of this programming error.

In particular because the same problem may exist elsewhere. Could you check the other callers
of {{getScheme}} that they handle the exception case correctly? Did you consider throwing
a checked exception from {{getScheme}} instead?

> ProxySelectorRoutePlanner doesn't handle IllegalStateException thrown by SchemeRegistry.getScheme
> -------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1688
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1688
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.5
>            Reporter: Tobias Oberlies
>
> Unlike e.g. the {{DefaultHttpRoutePlanner}}, the {{ProxySelectorRoutePlanner}} doesn't
handle the {{IllegalStateException}} that is thrown by {{SchemeRegistry.getScheme}} when using
an unknown scheme. This means that the {{IllegalStateException}} is thrown all the way to
the caller, e.g. {{HttpClient.execute}}.
> I suppose that the exception should be handled and converted into one of the checked
exceptions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message