hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philippe Mouawad (JIRA)" <j...@apache.org>
Subject [jira] [Reopened] (HTTPCLIENT-1665) Regression in org.apache.http.entity.mime.MultipartEntity
Date Mon, 19 Oct 2015 20:36:27 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Philippe Mouawad reopened HTTPCLIENT-1665:
------------------------------------------

Hi Oleg,
Sorry for late reply.
We face the issue when upgrading JMeter libraries from 4.2.6 to 4.5.1 and running the junit
 tests in JMeter
https://github.com/apache/jmeter/blob/trunk/test/src/org/apache/jmeter/protocol/http/sampler/TestHTTPSamplersAgainstHttpMirrorServer.java

Failure is:
{code:text}
     [java] Time: 72.39
     [java] There were 2 failures:
     [java] 1) testPostRequest_FormMultipart3(org.apache.jmeter.protocol.http.sampler.TestHTTPSamplersAgainstHttpMirrorServer)junit.framework.AssertionFailedError:
arrays have different length, expected is 402, actual is 366
     [java]     at org.apache.jmeter.protocol.http.sampler.TestHTTPSamplersAgainstHttpMirrorServer.checkArraysHaveSameContent(TestHTTPSamplersAgainstHttpMirrorServer.java:1240)
     [java]     at org.apache.jmeter.protocol.http.sampler.TestHTTPSamplersAgainstHttpMirrorServer.checkPostRequestFormMultipart(TestHTTPSamplersAgainstHttpMirrorServer.java:831)
     [java]     at org.apache.jmeter.protocol.http.sampler.TestHTTPSamplersAgainstHttpMirrorServer.testPostRequest_FormMultipart(TestHTTPSamplersAgainstHttpMirrorServer.java:342)
     [java]     at org.apache.jmeter.protocol.http.sampler.TestHTTPSamplersAgainstHttpMirrorServer.testPostRequest_FormMultipart3(TestHTTPSamplersAgainstHttpMirrorServer.java:153)
     [java]     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     [java]     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
     [java]     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     [java]     at junit.extensions.TestDecorator.basicRun(TestDecorator.java:23)
     [java]     at junit.extensions.TestSetup$1.protect(TestSetup.java:23)
     [java]     at junit.extensions.TestSetup.run(TestSetup.java:27)
     [java]     at org.apache.jorphan.test.AllTests.main(AllTests.java:236)
     [java] 2) testPostRequest_FileUpload3(org.apache.jmeter.protocol.http.sampler.TestHTTPSamplersAgainstHttpMirrorServer)junit.framework.AssertionFailedError:
arrays have different length, expected is 677, actual is 641
     [java]     at org.apache.jmeter.protocol.http.sampler.TestHTTPSamplersAgainstHttpMirrorServer.checkArraysHaveSameContent(TestHTTPSamplersAgainstHttpMirrorServer.java:1240)
     [java]     at org.apache.jmeter.protocol.http.sampler.TestHTTPSamplersAgainstHttpMirrorServer.checkPostRequestFileUpload(TestHTTPSamplersAgainstHttpMirrorServer.java:893)
     [java]     at org.apache.jmeter.protocol.http.sampler.TestHTTPSamplersAgainstHttpMirrorServer.testPostRequest_FileUpload(TestHTTPSamplersAgainstHttpMirrorServer.java:441)
     [java]     at org.apache.jmeter.protocol.http.sampler.TestHTTPSamplersAgainstHttpMirrorServer.testPostRequest_FileUpload3(TestHTTPSamplersAgainstHttpMirrorServer.java:165)
     [java]     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     [java]     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
     [java]     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     [java]     at junit.extensions.TestDecorator.basicRun(TestDecorator.java:23)
     [java]     at junit.extensions.TestSetup$1.protect(TestSetup.java:23)
     [java]     at junit.extensions.TestSetup.run(TestSetup.java:27)
     [java]     at org.apache.jorphan.test.AllTests.main(AllTests.java:236)
     [java] FAILURES!!!
{code}


Some contributor has fixed it this way:
https://github.com/redline13/jmeter/commit/6fbf9933aff1a2cca29e7ecc6c8b08e102514ce7#diff-4e3471b25c91730a99ed23402467b9eaR997

But is this regular ?
Thanks
Regards

> Regression in org.apache.http.entity.mime.MultipartEntity
> ---------------------------------------------------------
>
>                 Key: HTTPCLIENT-1665
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1665
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpMime
>    Affects Versions: 4.5
>            Reporter: Philippe Mouawad
>              Labels: regression
>             Fix For: 4.5.1
>
>
> As per org.apache.http.entity.mime.MultipartEntity constructor documentation:
> > @param charset the character set to use, may be {@code null}, in which case {@link
MIME#DEFAULT_CHARSET} - i.e. US-ASCII - is used.
> But it appears that in 4.5 version, if null is passed then no charset part is written.
> The same issue exists for  FormBodyPart.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message