Mailing-List: contact dev-help@hc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpComponents Project" <dev@hc.apache.org>
Message-ID: <55C790DA.1060507@apache.org>
Date: Sun, 09 Aug 2015 19:41:46 +0200
From: Michael Osipov <michaelo@apache.org>
User-Agent: Mozilla/5.0 (Windows NT 5.1;
 rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: HttpComponents Project <dev@hc.apache.org>
Subject: Some comments on recent auth API changes
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

Oleg,

just have noticed that you started to rewrite the auth API, here are a 
few issues which need some improvement:

1. httpclient/src/main/java/org/apache/http/auth/AuthScheme.java:
    #getPrinciple That is supposed to be #getPricipal and not
    #getPrinciple.

2. Rename AuthState in AuthExchange: while this is a good thing, all
    instance variables spread through the code have not been renamed and
    are therefore inconsistent/confusing. Same applies for the getters
    and final statics in HttpClientContext.

3. Revision: 1692371 AuthScheme API changes; User credentials made
    optional for those schemes that do not require them. while this is a
    vital, I do not fully understand how this now works. Can you sum up
    your change in a few words or sentences?

Michael

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org