hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michael-o <...@git.apache.org>
Subject [GitHub] httpclient pull request: URIBuilder extended for new method for em...
Date Thu, 27 Aug 2015 09:00:14 GMT
Github user michael-o commented on the pull request:

    https://github.com/apache/httpclient/pull/35#issuecomment-135349737
  
    @CanardSauvage as most folks are used to Commons Lang with `StringUtils#isEmpty`, the
method shall be named `add...NotEmpty`. I would still prefer method overloading with a boolean
parameter.
    
    @ok2c Please have a look ath the test case, line 160. This does not look like a valid
URI to me. As per RFC 3986, spaces are encoded with a space sign and not plus sign. This is
form encoded. Is that a bug in the URI builder? I'd rather go for standards-compliance in
5.0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message