hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From CanardSauvage <...@git.apache.org>
Subject [GitHub] httpclient pull request: URIBuilder extended for new method for em...
Date Tue, 25 Aug 2015 11:38:04 GMT
Github user CanardSauvage commented on the pull request:

    https://github.com/apache/httpclient/pull/35#issuecomment-134560658
  
    Maybe complete is the wrong word. The class is for proper URL building and this is a convenience
method that helps to reduce code. It would make the class easier to use, so why not add this
method?
    
    As explained, there are two possibilities - you want to build an url and you don't want
empty values or you want more control and you want to explicitly add only the key. But this
does not really matter if you can give the user the possibility for both with two methods
- so he can choose what he exactly wants. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message