hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: Some comments on recent auth API changes
Date Sun, 09 Aug 2015 18:19:38 GMT
On Sun, 2015-08-09 at 19:41 +0200, Michael Osipov wrote:
> Oleg,
> 
> just have noticed that you started to rewrite the auth API, here are a 
> few issues which need some improvement:
> 
> 1. httpclient/src/main/java/org/apache/http/auth/AuthScheme.java:
>     #getPrinciple That is supposed to be #getPricipal and not
>     #getPrinciple.
> 

My bad. Please go ahead and rename it.

> 2. Rename AuthState in AuthExchange: while this is a good thing, all
>     instance variables spread through the code have not been renamed and
>     are therefore inconsistent/confusing. Same applies for the getters
>     and final statics in HttpClientContext.
> 

Likewise.

> 3. Revision: 1692371 AuthScheme API changes; User credentials made
>     optional for those schemes that do not require them. while this is a
>     vital, I do not fully understand how this now works. Can you sum up
>     your change in a few words or sentences?
> 

I was going to write everything up in a few days, post it to the list
and basically pass everything over to you. I also did my very best to
describe how the new API were supposed to work in AuthScheme javadocs
but admittedly I am not much of a writer. Take a look at the
AuthScheme#isResponseReady method. Essentially the idea is to enable
AuthScheme to decide whether or not it needs user credentials to
proceed. Username / password based schemes would need to get credentials
from the credentials provider in order to proceed. More complex schemes
may always return true from this method and obtain user credentials by
some other means.

I am in the process of making last minor changes to the auth APIs. I'll
happily step away in a few days and you are welcome to take the lead
from there on.

Oleg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message