hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1246) Patch for JmxEnabledHttpClient
Date Mon, 27 Jul 2015 16:19:05 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642940#comment-14642940
] 

Oleg Kalnichevski commented on HTTPCLIENT-1246:
-----------------------------------------------

The project you are referring to looks inactive and I have no control over the repository
and cannot merge the PR in question. I am also no longer sure if HttpClient, as a project,
should even ship a JMX module. I am going to close this issue as WONTFIX.

Oleg

> Patch for JmxEnabledHttpClient
> ------------------------------
>
>                 Key: HTTPCLIENT-1246
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1246
>             Project: HttpComponents HttpClient
>          Issue Type: New Feature
>          Components: HttpClient
>            Reporter: Mike Boyers
>             Fix For: Future
>
>         Attachments: jmx-enabled-httpclient.patch
>
>
> Oleg asked me to submit this patch via JIRA.  This is an initial version of code to enable
JMX for requests/timeouts/etc.
> I've uploaded the patch as an attachment.
> Here are my comments about what I have and have not done.  This is from an email earlier
in the week:
> What I have at this point is a version of a JmxEnabledHttpClient that implements the
HttpClient interface.  You can instantiate a JmxEnabledHttpClient given an HttpClient.  I
have decoupled it from the work I had done previously (Spring-dependent), so it works without
any additional dependencies.  I probably just need a couple more hours to clean this area
up.  I did work on it a bit yesterday.
> But I have not made progress in integrating the stats more closely with the HttpClient
codebase.  So it doesn't currently have visibility into some of the underlying behavior of
HttpClient and some of the mechanisms for retaining and managing statistics could probably
be done more cheaply if they were integrated more closely.  This is the area I just don't
think I'm going to be able to find the time to do, sadly.
> So what I'm thinking at this point: I'll hand off what I've done (which is functional)
and you guys can decide on whether or not to use it as the basis for anything going forward.
 Even if you decide not to ultimately check it in with the rest of the HttpClient code, it
could still be useful to you in the short-term, as it could easily be turned into its own
jar and used with the existing HttpClient.  I'm pretty sure it records everything we talked
about previous except the current pool size.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message