Return-Path: X-Original-To: apmail-hc-dev-archive@www.apache.org Delivered-To: apmail-hc-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 809A7186B8 for ; Wed, 3 Jun 2015 16:58:25 +0000 (UTC) Received: (qmail 27296 invoked by uid 500); 3 Jun 2015 16:58:25 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 27254 invoked by uid 500); 3 Jun 2015 16:58:25 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 27240 invoked by uid 99); 3 Jun 2015 16:58:25 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jun 2015 16:58:25 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 0D875E0914; Wed, 3 Jun 2015 16:58:25 +0000 (UTC) From: hirthwork To: dev@hc.apache.org Reply-To: dev@hc.apache.org Message-ID: Subject: [GitHub] httpclient pull request: Cache request line in HttpRequestWrapper Content-Type: text/plain Date: Wed, 3 Jun 2015 16:58:25 +0000 (UTC) GitHub user hirthwork opened a pull request: https://github.com/apache/httpclient/pull/32 Cache request line in HttpRequestWrapper Copy of https://github.com/apache/httpclient/pull/31 for 4.5.x For each request HttpAsyncClient calls HttpRequestWrapper.getRequestLine() 8 times during single request execution. For URIs containing non-ASCII characters this causes tons of allocations and completely ruins performance. According to out tests RequestLine caching successfully addresses the issue with the cost of single long living object. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hirthwork/httpclient 4.5.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/httpclient/pull/32.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #32 ---- commit 7ce6c372612ff05639a2f4cb12e410f35fa458a7 Author: Dmitry Potapov Date: 2015-06-03T16:56:15Z Cache request line in HttpRequestWrapper ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org