Return-Path: X-Original-To: apmail-hc-dev-archive@www.apache.org Delivered-To: apmail-hc-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BE65517300 for ; Thu, 4 Jun 2015 12:08:38 +0000 (UTC) Received: (qmail 86015 invoked by uid 500); 4 Jun 2015 12:08:38 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 85966 invoked by uid 500); 4 Jun 2015 12:08:38 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 85954 invoked by uid 99); 4 Jun 2015 12:08:38 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Jun 2015 12:08:38 +0000 Date: Thu, 4 Jun 2015 12:08:38 +0000 (UTC) From: "Oleg Kalnichevski (JIRA)" To: dev@hc.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HTTPCLIENT-1656) Client Builder doesn't expose setValidateAfterInactivity(int) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HTTPCLIENT-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572646#comment-14572646 ] Oleg Kalnichevski commented on HTTPCLIENT-1656: ----------------------------------------------- I assigned the issue to 5.0, did not I? This is all I can do at the moment. If for whatever reason we decide to release 4.6 before 5.0, I'll re-assign this issue to 4.6. Oleg > Client Builder doesn't expose setValidateAfterInactivity(int) > ------------------------------------------------------------- > > Key: HTTPCLIENT-1656 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1656 > Project: HttpComponents HttpClient > Issue Type: Improvement > Components: HttpClient > Affects Versions: 4.4.1 > Reporter: yair ogen > Priority: Minor > Fix For: 5.0 > > > The API 'setStaleConnectionCheckEnabled' on the RequestConfig Builder is deprecated. It points to calling 'setValidateAfterInactivity' on the PoolingHttpClientConnectionManager class. > However we shouldn't mandate creating our own PoolingHttpClientConnectionManager instance (instead of reusing the one created automatically by the httpClient builder) just to setValidateAfterInactivity. > We should expose on the client/request config builder a setValidateAfterInactivity like we do for 'setMaxConnPerRoute' and 'setMaxConnTotal' (which in the builder are later set on the internally created PoolingHttpClientConnectionManager ). -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org