hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hirthwork <...@git.apache.org>
Subject [GitHub] httpclient pull request: Cache request line in HttpRequestWrapper
Date Wed, 03 Jun 2015 16:58:25 GMT
GitHub user hirthwork opened a pull request:

    https://github.com/apache/httpclient/pull/32

    Cache request line in HttpRequestWrapper

    Copy of https://github.com/apache/httpclient/pull/31 for 4.5.x
    
    For each request HttpAsyncClient calls HttpRequestWrapper.getRequestLine() 8 times during
single request execution. For URIs containing non-ASCII characters this causes tons of allocations
and completely ruins performance.
    According to out tests RequestLine caching successfully addresses the issue with the cost
of single long living object.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hirthwork/httpclient 4.5.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/httpclient/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #32
    
----
commit 7ce6c372612ff05639a2f4cb12e410f35fa458a7
Author: Dmitry Potapov <dpotapov@yandex-team.ru>
Date:   2015-06-03T16:56:15Z

    Cache request line in HttpRequestWrapper

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message