Return-Path: X-Original-To: apmail-hc-dev-archive@www.apache.org Delivered-To: apmail-hc-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0995210279 for ; Mon, 16 Feb 2015 20:48:18 +0000 (UTC) Received: (qmail 17588 invoked by uid 500); 16 Feb 2015 20:48:11 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 17542 invoked by uid 500); 16 Feb 2015 20:48:11 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 17531 invoked by uid 99); 16 Feb 2015 20:48:11 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Feb 2015 20:48:11 +0000 Date: Mon, 16 Feb 2015 20:48:11 +0000 (UTC) From: "Ronald Brill (JIRA)" To: dev@hc.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HTTPCLIENT-1614) Domain processing incompatible with 4.3.6 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HTTPCLIENT-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323265#comment-14323265 ] Ronald Brill commented on HTTPCLIENT-1614: ------------------------------------------ Is there a way to get the whole attribute map or do i have to ask for every possible attrib separately? > Domain processing incompatible with 4.3.6 > ----------------------------------------- > > Key: HTTPCLIENT-1614 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1614 > Project: HttpComponents HttpClient > Issue Type: Bug > Components: HttpClient > Affects Versions: 4.4 Final > Reporter: Ronald Brill > > Hi Oleg, > last week we have updated HtmlUnit (SNAPSHOT) from 4.3.6 to 4.4. During that we noticed a major difference. After some debugging i guess i found the reason. > The BasicDomainHandler#match impl checks for the existence of a attribute (DOMAIN_ATTR). Because we are building our own the cookies (using the constructur and some getter/setter and not parsing some headers), the attrib map is empty. But of course the domain attribute is set. > It will help, if the match impl will check the real fields instead of the attrib map. Additionally this will be more consistent because the domainMatch method already uses the domain field and not the value from the attrib map. > What do you think? -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org