Return-Path: X-Original-To: apmail-hc-dev-archive@www.apache.org Delivered-To: apmail-hc-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D6A1810D34 for ; Wed, 11 Feb 2015 13:04:14 +0000 (UTC) Received: (qmail 91816 invoked by uid 500); 11 Feb 2015 13:04:12 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 91775 invoked by uid 500); 11 Feb 2015 13:04:12 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 91742 invoked by uid 99); 11 Feb 2015 13:04:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Feb 2015 13:04:12 +0000 Date: Wed, 11 Feb 2015 13:04:11 +0000 (UTC) From: "Michael Osipov (JIRA)" To: dev@hc.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HTTPCORE-395) VersionInfo#getUserAgent reports incorrect Java version MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HTTPCORE-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316170#comment-14316170 ] Michael Osipov commented on HTTPCORE-395: ----------------------------------------- Changed 4.4.x with [r1658945|http://svn.apache.org/r1658945]. I will apply the original patch to 5.0. > VersionInfo#getUserAgent reports incorrect Java version > ------------------------------------------------------- > > Key: HTTPCORE-395 > URL: https://issues.apache.org/jira/browse/HTTPCORE-395 > Project: HttpComponents HttpCore > Issue Type: Bug > Components: HttpCore > Affects Versions: 4.4 > Reporter: Michael Osipov > Assignee: Michael Osipov > Fix For: 4.4.1, 5.0-alpha1 > > > Currently {{VersionInfo#getUserAgent}} sets {{Java 1.5 minimum}} by default but both [HttpCore|http://hc.apache.org/httpcomponents-core-4.4.x/httpcore/project-summary.html] and [HttpClient|http://hc.apache.org/httpcomponents-client-4.4.x/httpclient/project-summary.html] have Java 1.6 now. Values are completely ignored. > This needs to be determined at runtime. The best approach would be add a manifest property {{X-Compile-Target-JDK}} just like {{[commons-parent|http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?view=markup#l506]}} does. {{VersionInfo}} can be changed and report that information. > Alternatively, this information can be completely dropped. > The output now is > {noformat} > [http-8081-1] DEBUG org.apache.http.wire - http-outgoing-44 >> "User-Agent: Apache-HttpClient/4.4 (Java 1.5 minimum; Java/1.7.0_55)[\r][\n]" > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org