Mailing-List: contact dev-help@hc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpComponents Project" <dev@hc.apache.org>
Date: Thu, 5 Feb 2015 22:54:34 +0000 (UTC)
From: "Marcos Scriven (JIRA)" <jira@apache.org>
To: dev@hc.apache.org
Message-ID: <JIRA.12772831.1423171715000.272724.1423176874778@Atlassian.JIRA>
In-Reply-To: <JIRA.12772831.1423171715000@Atlassian.JIRA>
References: <JIRA.12772831.1423171715000@Atlassian.JIRA>
 <JIRA.12772831.1423171715781@arcas>
Subject: [jira] [Updated] (HTTPCLIENT-1607) Change
 ContextAwareAuthScheme.authenticate to return a HeaderGroup instead of a
 single Header
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marcos Scriven updated HTTPCLIENT-1607:
---------------------------------------
    Description: 
While writing a custom {{AuthScheme}}, I needed to add multiple headers to the request.

This is of course possible just by directly adding them to the request available as a parameter, but then it makes the return value rather arbitrary. Returning null seems to work, and is just silently ignored.

I think it would be more flexible to change the interface to return a `HeaderGroup`.

I guess an alternative would be to write a custom filter somewhere, but that wouldn't tie in nicely with authentication caches and user credentials automatically being applied according to the host route.

  was:
While writing a custom `AuthScheme`, I needed to add multiple headers to the request.

This is of course possible just by directly adding them to the request available as a parameter, but then it makes the return value rather arbitrary. Returning null seems to work, and is just silently ignored.

I think it would be more flexible to change the interface to return a `HeaderGroup`.

I guess an alternative would be to write a custom filter somewhere, but that wouldn't tie in nicely with authentication caches and user credentials automatically being applied according to the host route.


> Change ContextAwareAuthScheme.authenticate to return a HeaderGroup instead of a single Header
> ---------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1607
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1607
>             Project: HttpComponents HttpClient
>          Issue Type: Wish
>          Components: HttpClient
>    Affects Versions: 4.3.6
>            Reporter: Marcos Scriven
>            Priority: Minor
>             Fix For: 4.4 Final
>
>
> While writing a custom {{AuthScheme}}, I needed to add multiple headers to the request.
> This is of course possible just by directly adding them to the request available as a parameter, but then it makes the return value rather arbitrary. Returning null seems to work, and is just silently ignored.
> I think it would be more flexible to change the interface to return a `HeaderGroup`.
> I guess an alternative would be to write a custom filter somewhere, but that wouldn't tie in nicely with authentication caches and user credentials automatically being applied according to the host route.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org