Return-Path: X-Original-To: apmail-hc-dev-archive@www.apache.org Delivered-To: apmail-hc-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D92EF17339 for ; Sat, 14 Feb 2015 13:13:11 +0000 (UTC) Received: (qmail 65735 invoked by uid 500); 14 Feb 2015 13:13:11 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 65691 invoked by uid 500); 14 Feb 2015 13:13:11 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 65680 invoked by uid 99); 14 Feb 2015 13:13:11 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Feb 2015 13:13:11 +0000 Date: Sat, 14 Feb 2015 13:13:11 +0000 (UTC) From: "Oleg Kalnichevski (JIRA)" To: dev@hc.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (HTTPCORE-223) Thread-safety improvements MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HTTPCORE-223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCORE-223. ---------------------------------------- Resolution: Fixed Fix Version/s: (was: 5.0) 5.0-alpha1 Fixed in SVN trunk. Oleg > Thread-safety improvements > -------------------------- > > Key: HTTPCORE-223 > URL: https://issues.apache.org/jira/browse/HTTPCORE-223 > Project: HttpComponents HttpCore > Issue Type: Improvement > Components: HttpCore > Reporter: Sebb > Fix For: 5.0-alpha1 > > Attachments: threadsafety.patch > > > Thread-safety / isolation improvements to be considered for version 5.0 > ======================================================== > AbstractHttpEntity > has 3 protected fields, however there are public getters/setters for > all of the fields, so it seems to me that the fields should be > private. That would allow synch. to be added later if necessary. > HttpEntityWrapper > - wrappedEntity should be final. > AbstractHttpMessage > - headerGroup should be final > - params should be private > BasicHttpProcessor > requestInterceptors and responseInterceptors should be final > Should also be private, otherwise subclasses can subvert the non-null condition -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org