hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Osipov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1621) Possible NPE/incorrect type in HttpClientBuilder#evictIdleConnections
Date Fri, 27 Feb 2015 19:37:08 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14340687#comment-14340687
] 

Michael Osipov commented on HTTPCLIENT-1621:
--------------------------------------------

Sebastian, thanks for sharing. So your recommendation is to change in 4.5 only and add it
to the release notes?

The alternative would be to deprecate the whole method and create a new one with a primitive
value. Though, this seems a bit overdesigned. WDYT?

> Possible NPE/incorrect type in HttpClientBuilder#evictIdleConnections
> ---------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1621
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1621
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.4 Final
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>             Fix For: 4.4.1, 4.5 Alpha1
>
>
> The method accepts a {{Long}} as first arg and not {{long}} (simple type). This might
lead to an NPE.
> I think this is also safe to fix for 4.4.x because due to autoboxing this would be transparent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message