hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ronald Brill (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HTTPCLIENT-1614) Domain processing incompatible with 4.3.6
Date Mon, 16 Feb 2015 20:50:11 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ronald Brill updated HTTPCLIENT-1614:
-------------------------------------
    Description: 
Hi Oleg,

last week we have updated HtmlUnit (SNAPSHOT) from 4.3.6 to 4.4. During that we noticed a
major difference. After some debugging i guess i found the reason.
The BasicDomainHandler#match impl checks for the existence of a attribute (DOMAIN_ATTR). Because
we are building our own the cookies (using the constructor and some getter/setter and not
parsing some headers), the attrib map is empty. But of course the domain attribute is set.
It will help, if the match impl will check the real fields instead of the attrib map. Additionally
this will be more consistent because the domainMatch method already uses the domain field
and not the value from the attrib map.
What do you think?

  was:
Hi Oleg,

last week we have updated HtmlUnit (SNAPSHOT) from 4.3.6 to 4.4. During that we noticed a
major difference. After some debugging i guess i found the reason.
The BasicDomainHandler#match impl checks for the existence of a attribute (DOMAIN_ATTR). Because
we are building our own the cookies (using the constructur and some getter/setter and not
parsing some headers), the attrib map is empty. But of course the domain attribute is set.
It will help, if the match impl will check the real fields instead of the attrib map. Additionally
this will be more consistent because the domainMatch method already uses the domain field
and not the value from the attrib map.
What do you think?


> Domain processing incompatible with 4.3.6
> -----------------------------------------
>
>                 Key: HTTPCLIENT-1614
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1614
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.4 Final
>            Reporter: Ronald Brill
>
> Hi Oleg,
> last week we have updated HtmlUnit (SNAPSHOT) from 4.3.6 to 4.4. During that we noticed
a major difference. After some debugging i guess i found the reason.
> The BasicDomainHandler#match impl checks for the existence of a attribute (DOMAIN_ATTR).
Because we are building our own the cookies (using the constructor and some getter/setter
and not parsing some headers), the attrib map is empty. But of course the domain attribute
is set.
> It will help, if the match impl will check the real fields instead of the attrib map.
Additionally this will be more consistent because the domainMatch method already uses the
domain field and not the value from the attrib map.
> What do you think?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message