hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Walton (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HTTPCLIENT-1244) convert unit tests for cache module to use Mockito
Date Sun, 22 Feb 2015 12:46:17 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Joseph Walton updated HTTPCLIENT-1244:
--------------------------------------
    Attachment: 0001-HTTPCLIENT-1244-Move-many-httpclient-cache-tests-ove.patch

In the interests of consolidating on Mockito, I've taken a look at converting the majority
of the remaining tests (patch attached). It's a fairly mechanical conversion, which also drops
some unused mocking.

The remaining unconverted tests are the {{AbstractProtocolTest}} and {{TestCachingExec}} tests
which make more extensive use of matchers.

> convert unit tests for cache module to use Mockito
> --------------------------------------------------
>
>                 Key: HTTPCLIENT-1244
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1244
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpCache
>            Reporter: Jon Moore
>              Labels: test
>             Fix For: Future
>
>         Attachments: 0001-HTTPCLIENT-1244-Move-many-httpclient-cache-tests-ove.patch,
niceMockTransition_.patch
>
>
> Currently the unit tests for the caching module, while comprehensive, use strict mocks
from EasyMock. In many cases, these tests are brittle in ways they shouldn't be. Converting
to Mockito (as the rest of the httpclient codebase does) would potentially help here, as well
as unifying the unit test frameworks used across the codebase.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message