hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HTTPCLIENT-1587) Log warning if KeyManager instances are passed to SSLContext#init ?
Date Mon, 29 Dec 2014 16:43:13 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Oleg Kalnichevski resolved HTTPCLIENT-1587.
    Resolution: Won't Fix


Writing anything other than a fatal error to stderr would be extreme and, in my opinion, irresponsible.

I added a protected method to SSLContextBuilder that can be overwritten by a subclass in order
to perform extra trust / key material validation [1] If you absolutely insist I can create
an HttpClient specific subclass of SSLContextBuilder that logs extra SSL details as well as
warning for those cases where we think key material might be used incorrectly. However, I
personally think a note in javadocs added by you is perfectly sufficient.


[1] https://github.com/apache/httpcore/commit/76669c7c9894d93151a06a1d3cb1e1a9fa7888a3

> Log warning if KeyManager instances are passed to SSLContext#init ?
> -------------------------------------------------------------------
>                 Key: HTTPCLIENT-1587
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1587
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>            Reporter: Sebb
>            Priority: Minor
> Further to HTTPCLIENT-1585, maybe it would be worth logging a warning if HC detects that
multiple KeyManager instances are passed to SSLContext#init ?
> And/or note this in the appropriate Javadoc.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

View raw message