Return-Path: X-Original-To: apmail-hc-dev-archive@www.apache.org Delivered-To: apmail-hc-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E977017641 for ; Fri, 7 Nov 2014 02:57:34 +0000 (UTC) Received: (qmail 33085 invoked by uid 500); 7 Nov 2014 02:57:34 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 33052 invoked by uid 500); 7 Nov 2014 02:57:34 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 33037 invoked by uid 99); 7 Nov 2014 02:57:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Nov 2014 02:57:34 +0000 Date: Fri, 7 Nov 2014 02:57:34 +0000 (UTC) From: "Atkins (JIRA)" To: dev@hc.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HTTPCLIENT-1577) Some setting may not take effect if assigned HttpClientConnectionManager instance in HttpClientBuilder MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HTTPCLIENT-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atkins updated HTTPCLIENT-1577: ------------------------------- Description: If use set *setConnectionManager* method in *HttpClientBuilder*, some method like *setDefaultSocketConfig* or *setDefaultConnectionConfig* may not take effect. Should throw exception, write in javadoc or remove these method because it is duplicated. User should use *connectionManagerBuilder* to create custom connectionManager and use *setConnectionManager* to set it. example code: {code} HttpClients.custom() .setConnectionManager(...) .setDefaultSocketConfig(...) .setDefaultConnectionConfig(...) .setSSLSocketFactory(...) .setMaxConnTotal(...) .setMaxConnTotal(...) .build(); {code} All setXXX below setConnectionManager will not take any effect. was: If use set *setConnectionManager* method in *HttpClientBuilder*, some method like *setDefaultSocketConfig* or *setDefaultConnectionConfig* may not take effect. Should throw exception, write in javadoc or remove these method because it is duplicated. User should use *connectionManagerBuilder* to create custom connectionManager and use *setConnectionManager* to set it. example code: {code} HttpClients.custom() .setConnectionManager(...) .setDefaultSocketConfig(...) .setDefaultConnectionConfig(...) .setSSLSocketFactory(...) .setMaxConnTotal(...) .setMaxConnTotal(...) .build(...); {code} All setXXX below setConnectionManager will not take any effect. > Some setting may not take effect if assigned HttpClientConnectionManager instance in HttpClientBuilder > ------------------------------------------------------------------------------------------------------- > > Key: HTTPCLIENT-1577 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1577 > Project: HttpComponents HttpClient > Issue Type: Improvement > Components: HttpClient > Affects Versions: 4.3.3 > Reporter: Atkins > > If use set *setConnectionManager* method in *HttpClientBuilder*, some method like *setDefaultSocketConfig* or *setDefaultConnectionConfig* may not take effect. > Should throw exception, write in javadoc or remove these method because it is duplicated. User should use *connectionManagerBuilder* to create custom connectionManager and use *setConnectionManager* to set it. > example code: > {code} > HttpClients.custom() > .setConnectionManager(...) > .setDefaultSocketConfig(...) > .setDefaultConnectionConfig(...) > .setSSLSocketFactory(...) > .setMaxConnTotal(...) > .setMaxConnTotal(...) > .build(); > {code} > All setXXX below setConnectionManager will not take any effect. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org