hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Atkins (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HTTPCLIENT-1577) Some setting may not take effect if assigned HttpClientConnectionManager instance in HttpClientBuilder
Date Fri, 07 Nov 2014 02:57:34 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Atkins updated HTTPCLIENT-1577:
-------------------------------
    Description: 
If use set *setConnectionManager* method in *HttpClientBuilder*, some method like *setDefaultSocketConfig*
or *setDefaultConnectionConfig* may not take effect.
Should throw exception, write in javadoc or remove these method because it is duplicated.
User should use *connectionManagerBuilder* to create custom connectionManager and use *setConnectionManager*
to set it.

example code:
{code}
HttpClients.custom()
         .setConnectionManager(...)
         .setDefaultSocketConfig(...)
         .setDefaultConnectionConfig(...)
         .setSSLSocketFactory(...)
         .setMaxConnTotal(...)
         .setMaxConnTotal(...)
         .build();
{code}

All setXXX below setConnectionManager will not take any effect.

  was:
If use set *setConnectionManager* method in *HttpClientBuilder*, some method like *setDefaultSocketConfig*
or *setDefaultConnectionConfig* may not take effect.
Should throw exception, write in javadoc or remove these method because it is duplicated.
User should use *connectionManagerBuilder* to create custom connectionManager and use *setConnectionManager*
to set it.

example code:
{code}
HttpClients.custom()
         .setConnectionManager(...)
         .setDefaultSocketConfig(...)
         .setDefaultConnectionConfig(...)
         .setSSLSocketFactory(...)
         .setMaxConnTotal(...)
         .setMaxConnTotal(...)
         .build(...);
{code}

All setXXX below setConnectionManager will not take any effect.


> Some setting may not take effect if  assigned HttpClientConnectionManager instance in
HttpClientBuilder
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1577
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1577
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: 4.3.3
>            Reporter: Atkins
>
> If use set *setConnectionManager* method in *HttpClientBuilder*, some method like *setDefaultSocketConfig*
or *setDefaultConnectionConfig* may not take effect.
> Should throw exception, write in javadoc or remove these method because it is duplicated.
User should use *connectionManagerBuilder* to create custom connectionManager and use *setConnectionManager*
to set it.
> example code:
> {code}
> HttpClients.custom()
>          .setConnectionManager(...)
>          .setDefaultSocketConfig(...)
>          .setDefaultConnectionConfig(...)
>          .setSSLSocketFactory(...)
>          .setMaxConnTotal(...)
>          .setMaxConnTotal(...)
>          .build();
> {code}
> All setXXX below setConnectionManager will not take any effect.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message