hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Walton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1575) PoolingHttpClientConnectionManager.setMaxPerRoute accepts, but ignores, HttpRoutes with default ports
Date Fri, 07 Nov 2014 12:55:33 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202008#comment-14202008
] 

Joseph Walton commented on HTTPCLIENT-1575:
-------------------------------------------

Yes, that seems like a better place for the check; being able to rely on {{HttpRoute}} having
an explicit target port would make the invariant clearer.

It seems like it could break some compatibility, but I'd be happy to adapt any of my usage.

> PoolingHttpClientConnectionManager.setMaxPerRoute accepts, but ignores, HttpRoutes with
default ports
> -----------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1575
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1575
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>            Reporter: Joseph Walton
>         Attachments: HTTPCLIENT-1575-fail-when-setmaxperroute-uses-default-port.diff
>
>
> {{PoolingHttpClientConnectionManager.setMaxPerRoute}} can be called with an {{HttpRoute}}
constructed from an {{HttpHost}} using -1 to indicate the default port:
> {noformat}
> connectionManager.setMaxPerRoute(new HttpRoute(new HttpHost("localhost", -1, "http")));
> {noformat}
> However, when it's consulted during establishing a connection, the default port number
will have been filled in:
> {noformat}
> getMaxPerRoute(new HttpRoute(new HttpHost("localhost", 80, "http)));
> {noformat}
> The lookup for the maximum is by object equality, so this route will get the default
of 2.
> The simplest change here is to fail when an unspecified port is passed in, to indicate
that this is not supported. Alternatively, pass all {{HttpHost}} ports through {{DefaultSchemePortResolver.INSTANCE}}
before using them as keys in a map.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message