hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: My introduction and JIRA karma
Date Sun, 16 Nov 2014 12:08:26 GMT
On Sat, 2014-11-15 at 21:58 +0100, Michael Osipov wrote:
> Am 2014-11-15 um 14:27 schrieb Karl Wright:
> > Hi Michael,
> >
> > I understand how the workaround would work if I should implement it that
> > way, but I'm less certain about your proposed changes to HttpClient.  For
> > example, for proxies and NTLM this is what I currently do:
> >
> > CredentialsProvider credentialsProvider = new BasicCredentialsProvider();
> > credentialsProvider.setCredentials(
> >    new AuthScope(proxyHost, proxyPort),
> >    new NTCredentials(proxyAuthUsername, proxyAuthPassword, currentHost,
>                                                               ^^^^^^^^^^^
> Side note: this is actually redudant because HttpClient can deduce the 
> host itself. Don't know why you can pass this at all.

Please feel free to go ahead and deprecate the constructor, if you think
there is no legitimate reason to provide a custom local workstation
name.

Oleg



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message