hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Wright (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1557) NTLMEngine.Type1Message doesn't do anything with domain and host
Date Thu, 02 Oct 2014 11:17:33 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156380#comment-14156380

Karl Wright commented on HTTPCLIENT-1557:


The NTLM interaction was initially written to specification, as you may see in the comments.
 Later, due to the fact that some versions of Windows and some 3rd-party NTLM implementations
don't precisely adhere to that spec, certain functionality was disabled.  It is by no means
clear if or when conditional implementation may be needed.  For that reason, assembly of the
fields that were disabled has been left in place; this could be replaced by a comment, but
probably it would not be the right thing to do to structurally reorganize the NTLM engine
based on current usage.

> NTLMEngine.Type1Message doesn't do anything with domain and host
> ----------------------------------------------------------------
>                 Key: HTTPCLIENT-1557
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1557
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.2.6
>            Reporter: St├ęphane Landelle
> Since 4.2.3, NTLMEngine.Type1Message doesn't actually do anything with domain and host
parameters. It computes bytes from them, but don't do anything with those.
> Is this intended? I get that domain and host are optional, but should they really be
completely ignored?
> If so, Type1Message could be turned as a singleton, as the message ends up being always
the same.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

View raw message