hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1631076 - in /httpcomponents/httpclient-android/branches/4.3.5-android: RELEASE_NOTES.txt src/main/java/org/apache/http/impl/auth/BasicSchemeHC4.java
Date Sun, 12 Oct 2014 12:29:12 GMT
On 11 October 2014 17:15,  <olegk@apache.org> wrote:
> Author: olegk
> Date: Sat Oct 11 16:15:20 2014
> New Revision: 1631076
>
> URL: http://svn.apache.org/r1631076
> Log:
> HTTPCLIENT-1566: Fixed broken Base64 encoding in BasicScheme
>
> Modified:
>     httpcomponents/httpclient-android/branches/4.3.5-android/RELEASE_NOTES.txt
>     httpcomponents/httpclient-android/branches/4.3.5-android/src/main/java/org/apache/http/impl/auth/BasicSchemeHC4.java
>
> Modified: httpcomponents/httpclient-android/branches/4.3.5-android/RELEASE_NOTES.txt
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/4.3.5-android/RELEASE_NOTES.txt?rev=1631076&r1=1631075&r2=1631076&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/4.3.5-android/RELEASE_NOTES.txt (original)
> +++ httpcomponents/httpclient-android/branches/4.3.5-android/RELEASE_NOTES.txt Sat Oct
11 16:15:20 2014
> @@ -1,6 +1,9 @@
>  Changes since 4.3.5
>  -------------------
>
> +* [HTTPCLIENT-1566] Fixed broken Base64 encoding in BasicScheme
> +  Contributed by Oleg Kalnichevski <olegk at apache.org>

I thought the report (and suggested fix) was contributed by Rainer Burgstaller ?

> +
>  * [HTTPCLIENT-1554] RequestConfig has no effect when using Android HttpRequest classes.
>    Contributed by Oleg Kalnichevski <olegk at apache.org>
>
>
> Modified: httpcomponents/httpclient-android/branches/4.3.5-android/src/main/java/org/apache/http/impl/auth/BasicSchemeHC4.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/4.3.5-android/src/main/java/org/apache/http/impl/auth/BasicSchemeHC4.java?rev=1631076&r1=1631075&r2=1631076&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/4.3.5-android/src/main/java/org/apache/http/impl/auth/BasicSchemeHC4.java
(original)
> +++ httpcomponents/httpclient-android/branches/4.3.5-android/src/main/java/org/apache/http/impl/auth/BasicSchemeHC4.java
Sat Oct 11 16:15:20 2014
> @@ -159,7 +159,7 @@ public class BasicSchemeHC4 extends RFC2
>          tmp.append(":");
>          tmp.append((credentials.getPassword() == null) ? "null" : credentials.getPassword());
>
> -        final byte[] base64password = Base64.decode(
> +        final byte[] base64password = Base64.encode(
>                  EncodingUtils.getBytes(tmp.toString(), getCredentialsCharset(request)),
>                  Base64.NO_WRAP);
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message