Return-Path: X-Original-To: apmail-hc-dev-archive@www.apache.org Delivered-To: apmail-hc-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E899111E80 for ; Sun, 14 Sep 2014 12:16:33 +0000 (UTC) Received: (qmail 25128 invoked by uid 500); 14 Sep 2014 12:16:33 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 25085 invoked by uid 500); 14 Sep 2014 12:16:33 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 25073 invoked by uid 99); 14 Sep 2014 12:16:33 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 14 Sep 2014 12:16:33 +0000 Date: Sun, 14 Sep 2014 12:16:33 +0000 (UTC) From: "Joseph Walton (JIRA)" To: dev@hc.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HTTPCLIENT-1380) NTLMEngineImpl: Change exception message to be informative MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HTTPCLIENT-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14133190#comment-14133190 ] Joseph Walton commented on HTTPCLIENT-1380: ------------------------------------------- Although not fully informative, simply mentioning Unicode support may be an improvement here: {noformat} --- a/httpclient/src/main/java/org/apache/http/impl/auth/NTLMEngineImpl.java +++ b/httpclient/src/main/java/org/apache/http/impl/auth/NTLMEngineImpl.java @@ -1115,7 +1115,7 @@ final class NTLMEngineImpl implements NTLMEngine { if ((flags & FLAG_REQUEST_UNICODE_ENCODING) == 0) { throw new NTLMEngineException( - "NTLM type 2 message has flags that make no sense: " + "NTLM type 2 message indicates no support for Unicode. Flags are: " + Integer.toString(flags)); } {noformat} > NTLMEngineImpl: Change exception message to be informative > ---------------------------------------------------------- > > Key: HTTPCLIENT-1380 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1380 > Project: HttpComponents HttpClient > Issue Type: Improvement > Components: HttpAuth > Affects Versions: 4.2.5 > Reporter: Ricardo Pereira > Priority: Trivial > Fix For: Future > > > The class NTLMEngineImpl throws an exception when the NTLM server sends the challenge message with the field NTLMSSP_NEGOTIATE_UNICODE set to 0, but the exception message says "NTLM type 2 message has flags that make no sense: ". > The message gives no clue to what the problem is and forces the user to check the source code if (s)he wants to know why the exception was thrown. > Consider changing the exception message to report what the problem really is. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org