hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1554) defaultRequestConfig never used in InternalHttpClient
Date Wed, 17 Sep 2014 14:36:35 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137327#comment-14137327
] 

Oleg Kalnichevski commented on HTTPCLIENT-1554:
-----------------------------------------------

The Android port is a very hacky and painful workaround for the mess caused by Google's refusal
to upgrade HttpClient in Android. It is essentially a partial copy of an official release
with certain modifications on top of it. There is no way to create a proper Git repo out of
it. You will have to use SVN branch to get compilable source

http://svn.apache.org/repos/asf/httpcomponents/httpclient-android/branches/4.3.5-android/

Oleg

> defaultRequestConfig never used in InternalHttpClient
> -----------------------------------------------------
>
>                 Key: HTTPCLIENT-1554
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1554
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: Android Port
>    Affects Versions: 4.3.5
>         Environment: android
>            Reporter: Rob Smit
>              Labels: HttpClient
>             Fix For: 4.3.5.1-android
>
>
> after initializing builder en building client, the timeout settings are not used for
the request execution. In ClosableHttpClient.doExecute(), an on the fly request config is
used.
> my code:
>         builder = HttpClientBuilder.create();
>         int timeout = 30000;
>         defaultRequestConfig = RequestConfig.custom()
>                 .setSocketTimeout(timeout)
>                 .setConnectTimeout(timeout)
>                 .build();
>         builder.setDefaultRequestConfig(defaultRequestConfig);
>         List<Header> headers = new ArrayList<Header>();
>         headers.add(new BasicHeader("Accept", "application/json"));
>         builder.setDefaultHeaders(headers);
>         builder.useSystemProperties();
>         client = builder.build();
>         client.execute(request)
> timeout settings are never used!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message