hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCORE-390) Performance issue on AbstractNIOConnPool
Date Wed, 10 Sep 2014 15:28:34 GMT

    [ https://issues.apache.org/jira/browse/HTTPCORE-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128597#comment-14128597

ASF GitHub Bot commented on HTTPCORE-390:

GitHub user srouthiau opened a pull request:




You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srouthiau/httpcore trunk

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3
commit b998fe991e97e1ccef208350dbbca6c2a751359c
Author: srouthiau <stephane.routhiau@gmail.com>
Date:   2014-09-10T15:24:19Z

    Update AbstractNIOConnPool.java

commit 81c740937be7fb95cc42b195c15c6a185d5937ec
Author: srouthiau <stephane.routhiau@gmail.com>
Date:   2014-09-10T15:25:00Z

    Update RouteSpecificPool.java

commit dc8ebf14b0b21311ac2005a2e53de155439784a1
Author: srouthiau <stephane.routhiau@gmail.com>
Date:   2014-09-10T15:26:11Z

    Update SessionRequestCallback.java

commit 3895133eb24e585b80a8145c15aeb04e1ba74e07
Author: srouthiau <stephane.routhiau@gmail.com>
Date:   2014-09-10T15:27:04Z

    Update DefaultConnectingIOReactor.java


> Performance issue on AbstractNIOConnPool
> ----------------------------------------
>                 Key: HTTPCORE-390
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-390
>             Project: HttpComponents HttpCore
>          Issue Type: Improvement
>          Components: HttpCore NIO
>    Affects Versions: 4.3.2
>            Reporter: Stephane Routhiau
>              Labels: concurrency, performance
>         Attachments: AbstractNIOConnPool.java, DefaultConnectingIOReactor.java, RouteSpecificPool.java,
SessionRequestCallback.java, contention on lease and release.png, patch-performance nio pool.patch
> AbstractNIOConnPool use a ReentrantLock for lease and release connection.
> We have noticed important contention when we try to use hundreds of connexions to the
same host, the lock is to vast.
> I managed to rework a part of the code so there is no more use of a ReentrantLock, but
use of ConcurrentHashMap and so on.
> The unit tests are ok and the load tests we have made on the patch version are about
40 % faster under heavy load
> Please find attached patch file againt http-nio 4.3.2 and the modified sources files
of http-nio 4.3.2

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

View raw message