hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ok2c <...@git.apache.org>
Subject [GitHub] httpcore pull request: The HttpHost InetAddress constructor will u...
Date Wed, 06 Aug 2014 14:37:48 GMT
Github user ok2c commented on a diff in the pull request:

    https://github.com/apache/httpcore/pull/1#discussion_r15877520
  
    --- Diff: httpcore/src/main/java/org/apache/http/HttpHost.java ---
    @@ -262,9 +278,12 @@ public boolean equals(final Object obj) {
             }
             if (obj instanceof HttpHost) {
                 final HttpHost that = (HttpHost) obj;
    --- End diff --
    
    I am fine with adding another constructor, but I would prefer #hashCode and #equals to
do a simple value to value comparison instead of comparing some derived values.
    
    Oleg


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message