Return-Path: X-Original-To: apmail-hc-dev-archive@www.apache.org Delivered-To: apmail-hc-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3239711CA9 for ; Wed, 14 May 2014 13:11:56 +0000 (UTC) Received: (qmail 49951 invoked by uid 500); 14 May 2014 12:45:16 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 49908 invoked by uid 500); 14 May 2014 12:45:16 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 49892 invoked by uid 99); 14 May 2014 12:45:16 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 May 2014 12:45:16 +0000 Date: Wed, 14 May 2014 12:45:15 +0000 (UTC) From: "Michael Osipov (JIRA)" To: dev@hc.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HTTPCLIENT-1508) Default user agent should reflect the Java version used and not compiled MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HTTPCLIENT-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997510#comment-13997510 ] Michael Osipov commented on HTTPCLIENT-1508: -------------------------------------------- Oleg, what about using [{{VersionInfo#getUserAgent}}|https://hc.apache.org/httpcomponents-core-ga/httpcore/xref/org/apache/http/util/VersionInfo.html#316]? I can simply provide a patch for that? > Default user agent should reflect the Java version used and not compiled > ------------------------------------------------------------------------ > > Key: HTTPCLIENT-1508 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1508 > Project: HttpComponents HttpClient > Issue Type: Improvement > Components: HttpClient > Affects Versions: 4.3.3 > Reporter: Michael Osipov > Fix For: 4.4 Alpha1 > > > Currently, the dafault user agent looks like this: > {noformat} > DEFAULT_USER_AGENT = "Apache-HttpClient/" + release + " (java 1.5)" > {noformat} > This indicates that Java 1.5 is used but this is the compile target of HTTP Client. > A better user agent would be: > {noformat} > DEFAULT_USER_AGENT = "Apache-HttpClient/" + release + " (Java " + javaVersion ")" > {noformat} > where {{javaVersion}} is the version where the client is currently running. -- This message was sent by Atlassian JIRA (v6.2#6252) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org