hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1508) Default user agent should reflect the Java version used and not compiled
Date Wed, 14 May 2014 12:59:15 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997521#comment-13997521
] 

Oleg Kalnichevski commented on HTTPCLIENT-1508:
-----------------------------------------------

I would not drag that into HttpCore. I think this logic belongs to HttpClientBuilder (and
HttpAsyncClientBuilder). 

You can simply provide a patch by attaching it to this ticket or by raising a pull request
at github [1]

Oleg

[1] https://github.com/apache/httpclient

> Default user agent should reflect the Java version used and not compiled
> ------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1508
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1508
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: 4.3.3
>            Reporter: Michael Osipov
>             Fix For: 4.4 Alpha1
>
>
> Currently, the dafault user agent looks like this:
> {noformat}
> DEFAULT_USER_AGENT = "Apache-HttpClient/" + release + " (java 1.5)"
> {noformat}
> This indicates that Java 1.5 is used but this is the compile target of HTTP Client.
> A better user agent would be:
> {noformat}
> DEFAULT_USER_AGENT = "Apache-HttpClient/" + release + " (Java " + javaVersion ")"
> {noformat}
> where {{javaVersion}} is the version where the client is currently running.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message