Return-Path: X-Original-To: apmail-hc-dev-archive@www.apache.org Delivered-To: apmail-hc-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 41AA710B4E for ; Thu, 10 Apr 2014 12:55:26 +0000 (UTC) Received: (qmail 70208 invoked by uid 500); 10 Apr 2014 12:55:22 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 69928 invoked by uid 500); 10 Apr 2014 12:55:19 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 69877 invoked by uid 99); 10 Apr 2014 12:55:16 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Apr 2014 12:55:16 +0000 Date: Thu, 10 Apr 2014 12:55:16 +0000 (UTC) From: "Helmar Behrends (JIRA)" To: dev@hc.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HTTPCORE-372) ChunkedInputStream and ChunkDecoder allows closing chunk absence MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HTTPCORE-372?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D13= 965298#comment-13965298 ]=20 Helmar Behrends commented on HTTPCORE-372: ------------------------------------------ @Oleg: Yes, we used httpcore v4.3.2 plus the ChunkedInputStream implementat= ion which is attached to this ticket (we were not able to apply the Chunked= Encoder patch because it was not possbile to apply this patch to 4.3.2). > ChunkedInputStream and ChunkDecoder allows closing chunk absence > ---------------------------------------------------------------- > > Key: HTTPCORE-372 > URL: https://issues.apache.org/jira/browse/HTTPCORE-372 > Project: HttpComponents HttpCore > Issue Type: Improvement > Components: HttpCore, HttpCore NIO > Reporter: Dmitry Potapov > Fix For: 4.4-alpha1 > > Attachments: expect-closing-chunk-v2.patch, expect-closing-chunk.= patch > > > I've found that both these classes treats chunked streams without closing= chunk as complete streams without any errors. This contradicts RFC2616 =C2= =A73.6.1 > Consider the following scenario: > 1. HttpClient sends request to Server > 2. Server accepts request and send response headers with Transfer-Encodin= g: chunked > 3. Server sends first chunk completely and dies with segfault before send= ing the next chunk > 4. HttpClient receives response headers and creates ChunkedInputStream > 5. ChunkedInputStream reads this first chunk and encounters eof > Expected result: > IOException thrown indicating incomplete response > Actual result: > No exception is thrown, -1 is returned on the next read and nobody knows = that response is incomplete. -- This message was sent by Atlassian JIRA (v6.2#6252) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org