hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Brown (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HTTPCLIENT-1495) Finalizer in PoolingHttpClientConnectionManager should not log "shutdown" messages if already shutdown normally
Date Mon, 14 Apr 2014 14:42:14 GMT
Christopher Brown created HTTPCLIENT-1495:
---------------------------------------------

             Summary: Finalizer in PoolingHttpClientConnectionManager should not log "shutdown"
messages if already shutdown normally
                 Key: HTTPCLIENT-1495
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1495
             Project: HttpComponents HttpClient
          Issue Type: Improvement
          Components: HttpConn
    Affects Versions: 4.3.1
            Reporter: Christopher Brown
            Priority: Minor


Despite shutting down the CloseableHttpClient instance using "close()", which in turn calls
shutdown() on the PoolingHttpClientConnectionManager, messages are still logged such as the
following in all cases after a JVM garbage collection:

[Finalizer] DEBUG o.a.h.i.c.PoolingHttpClientConnectionManager - Connection manager is shutting
down

The finalizer thread always calls "shutdown", which always logs the "shutdown" messages. 
This led me to believe (when tracking memory leaks) that there was a problem in my usage of
HTTP client, when in fact the message was just misleading (everything was fine).

It would be preferable, perhaps via a volatile boolean instance field on the connection manager,
to suppress the shutdown messages (and maybe even suppress redundant resource cleanup attempts).
 This would help users of the library to concentrate on other issues.

Thanks.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message