hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HTTPCLIENT-1494) StringBody constructor throws NPE if text is null
Date Wed, 09 Apr 2014 11:45:16 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Oleg Kalnichevski resolved HTTPCLIENT-1494.
-------------------------------------------

       Resolution: Fixed
    Fix Version/s: 4.4 Alpha1
                   4.3.4

Fixed in SVN trunk and 4.3.x branch. 

Please review / re-test.

Oleg

> StringBody constructor throws NPE if text is null
> -------------------------------------------------
>
>                 Key: HTTPCLIENT-1494
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1494
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpMime
>    Affects Versions: 4.3.1, 4.3.3
>            Reporter: Tomasz KalkosiƄski
>             Fix For: 4.3.4, 4.4 Alpha1
>
>
> {code}
> public StringBody(final String text, final ContentType contentType)
> {code}
> This constructor throws NPE on text.getBytes(Charset) if passed text is null. 
> Also, this constructor lacks javadoc.
> I think that is should handle null text gracefully, or throw IllegalArgumentException
like it's documented on other constructors in case of null text.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message