hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Helmar Behrends (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCORE-372) ChunkedInputStream and ChunkDecoder allows closing chunk absence
Date Thu, 10 Apr 2014 12:55:16 GMT

    [ https://issues.apache.org/jira/browse/HTTPCORE-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965298#comment-13965298
] 

Helmar Behrends commented on HTTPCORE-372:
------------------------------------------

@Oleg: Yes, we used httpcore v4.3.2 plus the ChunkedInputStream implementation which is attached
to this ticket (we were not able to apply the ChunkedEncoder patch because it was not possbile
to apply this patch to 4.3.2).

> ChunkedInputStream and ChunkDecoder allows closing chunk absence
> ----------------------------------------------------------------
>
>                 Key: HTTPCORE-372
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-372
>             Project: HttpComponents HttpCore
>          Issue Type: Improvement
>          Components: HttpCore, HttpCore NIO
>            Reporter: Dmitry Potapov
>             Fix For: 4.4-alpha1
>
>         Attachments: expect-closing-chunk-v2.patch, expect-closing-chunk.patch
>
>
> I've found that both these classes treats chunked streams without closing chunk as complete
streams without any errors. This contradicts RFC2616 ยง3.6.1
> Consider the following scenario:
> 1. HttpClient sends request to Server
> 2. Server accepts request and send response headers with Transfer-Encoding: chunked
> 3. Server sends first chunk completely and dies with segfault before sending the next
chunk
> 4. HttpClient receives response headers and creates ChunkedInputStream
> 5. ChunkedInputStream reads this first chunk and encounters eof
> Expected result:
> IOException thrown indicating incomplete response
> Actual result:
> No exception is thrown, -1 is returned on the next read and nobody knows that response
is incomplete.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message