Mailing-List: contact dev-help@hc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpComponents Project" <dev@hc.apache.org>
Received-SPF: pass (athena.apache.org: local policy includes SPF record at
 spf.trusted-forwarder.org)
Message-ID: <1395132425.11533.1.camel@ubuntu>
Subject: Re: case-conversion: standardise on Locale.ROOT (1.6) or
 Locale.ENGLISH (1.6)
From: Oleg Kalnichevski <olegk@apache.org>
To: HttpComponents Project <dev@hc.apache.org>
Date: Tue, 18 Mar 2014 09:47:05 +0100
In-Reply-To: 
 <CAOGo0VY7vfZnXeYTjF1j9B7sEJrshc-py=i0dfK1agnF-wwPVg@mail.gmail.com>
References: 
	<CAOGo0VY7vfZnXeYTjF1j9B7sEJrshc-py=i0dfK1agnF-wwPVg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

On Tue, 2014-03-18 at 01:04 +0000, sebb wrote:
> There are 83 instances of case conversion using a Locale (none
> without) in HC project trunk
> 
> Of these, there are:
> 
> 23 Locale.ENGLISH (includes 4 comments)
> 33 Locale.ROOT (Java 1.6+; httpasycclient currently uses 1.5)
> 27 Locale.US (httpclient/httpcore only)
> 
> It does not make sense to me to use US (or UK).
> Although they are short, they are too specific.
> ROOT is ideal, but is 1.6+
> 
> httpasyncclient only has 5 instances of Locale, two of which are comments.
> It only uses ENGLISH.
> 
> I propose to convert the Locale instances in client and core to ROOT.
> The httpasyncclient component can be done when it requires 1.6
> 
> OK?
> 

I think I have already changed all non-deprecated classes in core and
client to use Locale.ROOT. I see no point changing deprecated code.

Oleg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org