hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: svn commit: r1571715
Date Mon, 03 Mar 2014 22:28:40 GMT
On Mon, 2014-03-03 at 18:57 +0000, sebb wrote:
> On 3 March 2014 10:43, Oleg Kalnichevski <olegk@apache.org> wrote:
> > On Sun, 2014-03-02 at 01:24 +0000, sebb wrote:

...

> >>
> >> I don't know which of its fields are likely to be needed by the
> >> schedule() method apart from consecutiveFailedAttempts which already
> >> has a public getter.
> >> The trunk version now has a public getter for the identifier; for
> >> consistency perhaps that should also be added to 4.3.x?
> >>
> >>
> >
> > HttpClient 4.3 ships with two public implementations of this interface.
> > Those classes are likely to be enough for the majority of users. I would
> > rather not make any API changes to the stable branch unless absolutely
> > necessary.
> 
> In which case, I think the Javadoc needs to be updated to note this.
> 
> However, I just don't understand the rigid stance on API immutability.
> Yes, changes should be carefully reviewed to ensure that they make sense.
> But in this case the next release has already made the proposed change.
> And backwards compatibility is very unlikely to be an issue.
> 

We still have a chance to re-do those changes in the dev branch should
we find that necessary. We will not have that option anymore once 4.3.4
is out. 

Oleg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message