hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCORE-375) Remove unnecessary throws UnsupportedEncodingException
Date Fri, 21 Feb 2014 14:54:03 GMT

    [ https://issues.apache.org/jira/browse/HTTPCORE-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908400#comment-13908400

Sebb commented on HTTPCORE-375:

AFAIK, throws clauses are not part of the method signature, so this does not affect binary

However it will affect source compatibility - users would need to edit the source before recompiling.

> Remove unnecessary throws UnsupportedEncodingException
> ------------------------------------------------------
>                 Key: HTTPCORE-375
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-375
>             Project: HttpComponents HttpCore
>          Issue Type: Improvement
>          Components: HttpCore
>    Affects Versions: 4.4-alpha1
>            Reporter: Robin Skoglund
>            Priority: Minor
>             Fix For: Future
>         Attachments: HTTPCORE-375.patch
> StringEntity has constructors that unneccessarily declare 'throws UnsupportedEncodingException'.
This over-complicates client code because you have to set up a lot of "this should never happen"
exception handling.
> There's also a constructor that uses 'String.getBytes(String)', that should instead be
using 'String.getBytes(Charset)'.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

View raw message