hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: SchedulingStrategy API breakage; was Re: Change Javadoc show level?
Date Tue, 25 Feb 2014 18:51:26 GMT
On 25 February 2014 16:53, Oleg Kalnichevski <oleg@ok2consulting.com> wrote:
>
>>>
>>> I worked the problem around my making AsynchronousValidationRequest
>>> public while leaving its constructor package private.
>>
>>That should fix the Javadoc issue.
>>
>>Perhaps I'm missing something, but I'm not sure how external code can
>>invoke the schedule() method?
>>There does not seem to be a way to create an instance of the required
>>AsynchronousValidationRequest parameter except from the same package.
>>
>>Or perhaps the schedule() method is not supposed to be called
>>externally?
>>
>>In which case, why not just document that the method is only public
>>because it implements the interface, and is only intended for internal
>>use?
>>The changes to AsynchronousValidationRequest could then be reverted,
>>as there would be no need to reference the package-private class in
>>the Javadoc.
>
> Users are expected to implement this method. Without it the interface is pointless.

OK, I see now.
Sorry, was looking at it backwards.

There perhaps should be a test case in a different package to confirm this.

> Oleg
> --
> Sent from my Android device with K-9 Mail. Please excuse my brevity.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message