hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: Handling idle timeout disconnect
Date Sat, 22 Feb 2014 16:37:42 GMT
On Sat, 2014-02-22 at 14:52 +0000, sebb wrote:

...

> > IIRC, we disabled retries because they were causing unexpected extra
> > traffic to be sent to servers.
> > Also, generally testers need to know when requests fail, as it affects
> > throughput.
> >
> > So we may need our own retry handler for this specific case.
> 
> Actually, it looks like there may be a bug in the
> DefaultHttpRequestRetryHandler class which is why it was not suitable
> for JMeter.
> 
> We invoke it with the parameter requestSentRetryEnabled = false.
> 
> However we found that additional requests were being seen at the
> server, so we now default to zero retries.
> 
> I've just had a look at the code, and the parameter
> requestSentRetryEnabled seems to be applied too late.
> It is checked AFTER the check for idempotent requests.
> 
> So a GET will be resent even if requestSentRetryEnabled is false.
> That does not seem right.
> 
> Shall I raise a JIRA?
> 

DefaultHttpRequestRetryHandler implementation goes back to the dark ages
of HttpClient 2.x, but I think it was always intended to work that way.
So, it is a feature.

I am fine with changing the behavior, but in 4.4 branch. 

Oleg



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message