Mailing-List: contact dev-help@hc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpComponents Project" <dev@hc.apache.org>
Date: Tue, 14 Jan 2014 02:27:56 +0000 (UTC)
From: "Joe Campbell (JIRA)" <jira@apache.org>
To: dev@hc.apache.org
Message-ID: <JIRA.12644595.1366895518872.91124.1389666476058@arcas>
In-Reply-To: <JIRA.12644595.1366895518872@arcas>
References: <JIRA.12644595.1366895518872@arcas>
Subject: [jira] [Commented] (HTTPCLIENT-1347) gzip responses doubly cached
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870310#comment-13870310 ] 

Joe Campbell commented on HTTPCLIENT-1347:
------------------------------------------

Sorry about that - in the test client I put this back as you were saying the issue was around gzip responses:

httpGet.addHeader("Accept-Encoding", "gzip");

Hmm - in the disk caching case it would have to be smarter about the linking for the body (as jon pointed out above) it is linking the resource, so it isn't using double the space in memory (it is re-using the reference for the byte array). You are correct that the naive storage case is a direct out to disk of the in memory representation which would likely cause there to be an additional space usage. 

> gzip responses doubly cached
> ----------------------------
>
>                 Key: HTTPCLIENT-1347
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1347
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpCache
>    Affects Versions: 4.2.5
>         Environment: ARCH Linux kernel 3.8.8-1
> node.js 0.8.22
>            Reporter: Adam Patacchiola
>             Fix For: 4.4 Final
>
>         Attachments: Screen Shot 2014-01-11 at 7.11.36 PM.png, Screen Shot 2014-01-13 at 3.56.19 PM.png, Showing_entry_pointer.png, httpClientCacheTest.tar.gz, httpClientTestServer.js
>
>
> Compressed responses are cached twice. 
> Run the attached server (node.js 0.8.22) and client tests. Create an "assets" directory under where you are running the server and add two files named 1 and 2 ( < 1000000 bytes) . You will see that after the test is run the cache dump output displays 2 sets of entries for each request, each containing the full content length of the file.
> Changing the implementation of HttpCacheStorage updateEntry to not update non existent entries (as I believe the correct implementation should do) throws exceptions. 


--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org