Return-Path: X-Original-To: apmail-hc-dev-archive@www.apache.org Delivered-To: apmail-hc-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E7FA710EDE for ; Fri, 8 Nov 2013 16:37:21 +0000 (UTC) Received: (qmail 21335 invoked by uid 500); 8 Nov 2013 16:37:18 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 21301 invoked by uid 500); 8 Nov 2013 16:37:18 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 21285 invoked by uid 99); 8 Nov 2013 16:37:17 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Nov 2013 16:37:17 +0000 Date: Fri, 8 Nov 2013 16:37:17 +0000 (UTC) From: "jason mathews (JIRA)" To: dev@hc.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HTTPCLIENT-1433) DefaultClientConnectionOperator instance check inconsistent with explicit cast MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HTTPCLIENT-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jason mathews updated HTTPCLIENT-1433: -------------------------------------- Description: Class checks for LayeredConnectionSocketFactory instance then casts to SchemeLayeredSocketFactory at line 214. Assertion check needs to be for SchemeLayeredSocketFactory not LayeredConnectionSocketFactory in DefaultClientConnectionOperator.updateSecureConnection(). package org.apache.http.impl.conn; class DefaultClientConnectionOperator public void updateSecureConnection(...) { ... // line 214 Asserts.check(schm.getSchemeSocketFactory() instanceof LayeredConnectionSocketFactory, "Socket factory must implement SchemeLayeredSocketFactory"); final SchemeLayeredSocketFactory lsf = (SchemeLayeredSocketFactory) schm.getSchemeSocketFactory(); } was: Class checks for LayeredConnectionSocketFactory instance then casts to SchemeLayeredSocketFactory at line 214. Assertion check needs to be for SchemeLayeredSocketFactory not LayeredConnectionSocketFactory in DefaultClientConnectionOperator.updateSecureConnection(). package org.apache.http.impl.conn; class DefaultClientConnectionOperator updateSecureConnection() { ... // line 214 Asserts.check(schm.getSchemeSocketFactory() instanceof LayeredConnectionSocketFactory, "Socket factory must implement SchemeLayeredSocketFactory"); final SchemeLayeredSocketFactory lsf = (SchemeLayeredSocketFactory) schm.getSchemeSocketFactory(); } > DefaultClientConnectionOperator instance check inconsistent with explicit cast > ------------------------------------------------------------------------------ > > Key: HTTPCLIENT-1433 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1433 > Project: HttpComponents HttpClient > Issue Type: Bug > Components: HttpClient > Affects Versions: 4.3.1 > Environment: exists in all platforms. > Reporter: jason mathews > > Class checks for LayeredConnectionSocketFactory instance then casts to SchemeLayeredSocketFactory at line 214. > Assertion check needs to be for SchemeLayeredSocketFactory not LayeredConnectionSocketFactory in DefaultClientConnectionOperator.updateSecureConnection(). > package org.apache.http.impl.conn; > class DefaultClientConnectionOperator > public void updateSecureConnection(...) { > ... > // line 214 > Asserts.check(schm.getSchemeSocketFactory() instanceof LayeredConnectionSocketFactory, > "Socket factory must implement SchemeLayeredSocketFactory"); > final SchemeLayeredSocketFactory lsf = (SchemeLayeredSocketFactory) schm.getSchemeSocketFactory(); > } -- This message was sent by Atlassian JIRA (v6.1#6144) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org