hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCORE-363) Unnecessary call to isOpen() before calling close
Date Sun, 24 Nov 2013 17:19:35 GMT

    [ https://issues.apache.org/jira/browse/HTTPCORE-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830987#comment-13830987
] 

Oleg Kalnichevski commented on HTTPCORE-363:
--------------------------------------------

Sebastian
I think this was done in order to avoid exceptions thrown in case an attempt is made to close
a channel that has already been closed. It can well be this check is no longer necessary,
but I am not entirely sure. I would probably prefer to change this behavior in the 4.4 branch
only (once stable 4.3.x branch has been created). 

Oleg

> Unnecessary call to isOpen() before calling close
> -------------------------------------------------
>
>                 Key: HTTPCORE-363
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-363
>             Project: HttpComponents HttpCore
>          Issue Type: Improvement
>            Reporter: Sebb
>            Priority: Minor
>
> There are some instances of the following code:
> final Channel channel = this.key.channel();
> if (channel.isOpen()) {
>     try {
>         channel.close();
>     } catch (final IOException ignore) {}
> }
> Eclipse generates a warning that the channel might not be closed.
> Obviously that is a false positive, but why bother checking the state?
> Surely channel.close() can be repeated without harm?



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message