hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HTTPCORE-363) Unnecessary call to isOpen() before calling close
Date Sun, 24 Nov 2013 15:31:35 GMT
Sebb created HTTPCORE-363:

             Summary: Unnecessary call to isOpen() before calling close
                 Key: HTTPCORE-363
                 URL: https://issues.apache.org/jira/browse/HTTPCORE-363
             Project: HttpComponents HttpCore
          Issue Type: Improvement
            Reporter: Sebb
            Priority: Minor

There are some instances of the following code:

final Channel channel = this.key.channel();
if (channel.isOpen()) {
    try {
    } catch (final IOException ignore) {}

Eclipse generates a warning that the channel might not be closed.
Obviously that is a false positive, but why bother checking the state?
Surely channel.close() can be repeated without harm?

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

View raw message